spamguy/diplomacy-godip

Back propagate to godip

Opened this issue · 2 comments

zond commented

Hey,

If your changes to godip to make it JS friendly are not generally harmful, would you mind creating a pull request? :)

I thought about it earlier. It's not out of the question, but my changes are pretty aggressive: I shuffled the model relationships around quite a bit to permit arbitrary variant support. I'd wreck anything depending on your original repo for sure. Also, despite reaching my goal, the fact remains that I still write crappy Go. I'd be glad to make a pull request, but we should consult on the repercussions first, and perhaps have a code review.

zond commented

Sounds good :)

Perhaps we could do it step by step, in smaller changes that stay easy to
understand and motivate?

If you have the energy, you could create a series of issues in the godip
repo, describing the problems you ran into when trying to run it via JS.

Then we could address them one at a time in a not-too-scary manner.
On Jan 21, 2016 18:14, "spamguy" notifications@github.com wrote:

I thought about it earlier. It's not out of the question, but my changes
are pretty aggressive: I shuffled the model relationships around quite a
bit to permit arbitrary variant support. I'd wreck anything depending on
your original repo for sure. Also, despite reaching my goal, the fact
remains that I still write crappy Go. I'd be glad to make a pull request,
but we should consult on the repercussions first, and perhaps have a code
review.


Reply to this email directly or view it on GitHub
#1 (comment)
.