spamhaus/spamassassin-dqs

Regular expressions without '$'?

robert-scheck opened this issue · 1 comments

robert-scheck commented

Is it really intended that the following regular expressions are without a terminating $?

spamassassin-dqs/sh.cf

Line 73 in 4d08684

body SH_BODYURI_REVERSE_SBL eval:check_sh_bodyuri_a('your_DQS_key.zen.dq.spamhaus.net', '^127\.0\.0\.2')

spamassassin-dqs/sh.cf

Line 77 in 4d08684

body SH_BODYURI_REVERSE_CSS eval:check_sh_bodyuri_a('your_DQS_key.zen.dq.spamhaus.net', '^127\.0\.0\.3')

spamassassin-dqs/sh.cf

Line 81 in 4d08684

body SH_BODYURI_REVERSE_DROP eval:check_sh_bodyuri_a('your_DQS_key.zen.dq.spamhaus.net', '^127\.0\.0\.9')

spamassassin-dqs/sh.cf

Line 85 in 4d08684

body SH_BODYURI_REVERSE_XBL eval:check_sh_bodyuri_a('your_DQS_key.zen.dq.spamhaus.net', '^127\.0\.0\.4')

As of writing, not only a returned 127.0.0.2 would be matched by the first expression, but also e.g. a returned 127.0.0.255. And even if that behaviour is intended, all other rules do handle possible replies explicitly rather implicitly.

ricalfieri commented

You are correct and those regexes are now fixed