spamhaus/spamassassin-dqs

Multiple issues with SH_BODYURI_* rules

dwhitemv25 opened this issue · 2 comments

dwhitemv25 commented

I have found 2 issues with the SH_BODYURI_REVERSE_* rules in sh.cf.

  1. The rule definitions for the SH_BODYURI_REVERSE_* rules use the wrong URIDNSBL method. They are defined to use urirhssub, but query ZEN, which is a DNSBL list; they should use uridnssub instead, so the hostname is resolved to an IP first and that IP is looked up in ZEN.

The offending lines are in this block:
https://github.com/spamhaus/spamassassin-dqs/blob/b9ba6e4823c9e2dc4c27b1d167a751e6ad5d0f7d/4.0.0%2B/sh.cf#LL71C1-L95C1

  1. I spotted a copy-paste error here:

    spamassassin-dqs/4.0.0+/sh.cf

    Line 90 in b9ba6e4

    body SH_BODYURI_REVERSE_XBL eval:check_uridnsbl('SH_BODYURI_REVERSE_DROP')

    The body line should read:
  body		SH_BODYURI_REVERSE_XBL	eval:check_uridnsbl('SH_BODYURI_REVERSE_XBL')

This is on:

SpamAssassin version 4.0.0
  running on Perl version 5.32.1
FreeBSD spamassasin-dqs port version 1.4.0

I can generate a pull request if it is helpful.

Update: Found source of the first issue.

ricalfieri commented

Yes please do a pull request and I'll merge

dwhitemv25 commented

PR #61 opened as requested.