spandex-project/spandex_datadog

Add container metadata to traces

moleskin-smile opened this issue · 3 comments

moleskin-smile commented

Hey. For traces generated by Spandex there is no Kubernetes metadata and no container information in Datadog (see the screenshot).

image

Official libraries parse the /proc/self/cgroup file, getting container ID from there and passing it as Datadog-Container-ID headers in traces. Datadog agents do the rest.

Simple implementations:

  1. https://github.com/DataDog/dd-trace-go/pull/472/files
  2. https://github.com/DataDog/dd-trace-js/pull/612/files (essential part from third party library)

More comprehensive examples:

  1. https://github.com/DataDog/dd-trace-rb/pull/784/files (essential part)
  2. https://github.com/DataDog/dd-trace-py/pull/1007/files
zachdaniel commented

I'm happy to accept a feature to this effect, if you or someone else would like to contribute it!

  • ❤️1
moleskin-smile commented

Thanks, @zachdaniel! Fortunately someone did implement it: #38. :)

GregMefford commented

This has been resolved! Thanks again! 🚀 ❤️

  • 🎉1
  • ❤️1
  • 🚀1