spandex-project/spandex_datadog

Implement Sampling

Closed this issue · 1 comments

According to a conversation with Datadog, the Datadog agent does not down-sample itself, but expects the traces to be flagged, via :priority, to either keep or drop. Also, DD intends to charge for trace volume.

Would you consider a PR to implement this in this package? Possibly using an application env var?

Upon further review, sampling at the end of the process would be suboptimal. Distributed traces would not be consistently sampled the same way.
See a PR from my colleague for head-based sampling, which is what Datadog recommends.