available() should use signed integer

Question

available() should use signed integer

WayneKeenan opened this issue 6 years ago · 2 comments

The uint8_t on the line below should be an int8_t otherwise the comparison after is never true and it has a side effect of the client processing bogus readings.

https://github.com/sparkfun/SparkFun_MAX3010x_Sensor_Library/blob/master/src/MAX30105.cpp#L528

Answer 1 · 2018-03-28T16:45:56.000Z

You are very right! Thank you.

Answer 2 · 2018-03-28T17:15:51.000Z

Will be fixed in the latest release.