please tag `drongo` repo with the same tag as sparrow
nyxnor opened this issue · 3 comments
Great, please also tag drongo repo with the same tag else everytime a builder will need to set the commit manually.
Originally posted by @nyxnor in sparrowwallet/sparrow#192 (comment)
This would facilitate reproducibility instead of having to find which was the last commit made to drongo when sparrow is released.
I'm not sure I follow the reasoning for this. It's not standard to tag an upstream project whenever another project that depends on it has a release.
This would facilitate reproducibility instead of having to find which was the last commit made to drongo when sparrow is released.
The drongo commit for a particular tag of sparrowwallet is included in the submodule reference. For example, it's clear from https://github.com/sparrowwallet/sparrow/tree/1.7.1 that the drongo commit for this tag is https://github.com/sparrowwallet/drongo/tree/fa18ec9d458bb17221fb01b6be9f4eceb354a156.
problem is cloning sparrow and checking out the sparrow tag, doesn't change submodule commit/tag, so it is not automatable. Yes, from checking the tree we can see the drongo commit, but as this is not goind to be altered, closing.