[5.9.0] Artisan migrate throwing QueryException

Question

[5.9.0] Artisan migrate throwing QueryException

jure-knezovic opened this issue a year ago · 23 comments

After latest update to 5.9.0, php artisan migrate / migrate:fresh is throwing Query Exception.

SQLSTATE[42000]: Syntax error or access violation: 1166 Incorrect column name '' (SQL: create table model_has_permissions (`` bigint unsigned not null, model_type varchar(255) not null, `model_id` bigint unsigned not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')

Laravel: 9.50.2
Permission package: 5.9.0
PHP: 8.1
DB: mariadb 10.5

Steps to reproduce the behavior:

Create fresh Laravel App
composer require spatie/laravel-permission
Add HasRoles to User
php artisan migrate -> Query Exception

When permissions package is locked to 5.8.0, no QueryException is thrown.

Answer 1 · 2023-02-06T18:51:15.000Z

I can also confirm I am getting the same error. I discovered this when one of my deploy jobs failed doing the migration stage.

Answer 2 · 2023-02-06T18:55:03.000Z

Also trying to use this package in one of my new projects and facing the same error. For some reason the constructor in PermissionRegistrar class is not firing.

Answer 3 · 2023-02-06T19:01:21.000Z

Pull request fix: Lazily bind dependencies seems to have started the issue.

Answer 4 · 2023-02-06T19:01:56.000Z

One thing that comes to mind is the possibility of requiring a cache reset/refresh.

Answer 5 · 2023-02-06T19:28:43.000Z

Same here. Clearing cache and performing a fresh migration does not solve the issue. For now, pin the version to 5.8.0 and it will work fine again.

Answer 6 · 2023-02-06T19:42:39.000Z

I confirm the same error here. Can't run the package migration for 5.9.0.

Answer 7 · 2023-02-06T19:44:45.000Z

I can confirm the same error for Laravel 9 and 8 fresh installation, after clearing the config cache and fresh migration does not solve the problem

Answer 8 · 2023-02-06T19:45:07.000Z

Maybe related
#2319 (comment)

Answer 9 · 2023-02-06T19:49:14.000Z

Same issue noticed. There is nothing to clear in cache for permissions.

In migration file, the "PermissionRegistrar" class is not instantiated and hence its constructor is not being called & no value set for its static variable $pivotPermission. Hence the migration query showing a blank column name while creating table "model_has_permissions"

Answer 10 · 2023-02-06T19:51:43.000Z

@ashvin-php so, is #2309 the problem?

Answer 11 · 2023-02-06T19:59:31.000Z

@erikn69 At the moment I am not 100% sure about #2309 , but it looks like PermissionRegistrar class is not instantiated. I just looked at the migration file and PermissionRegistrar.php file for v5.9.0 in my machine.

Answer 12 · 2023-02-06T20:00:26.000Z

Confirming the problem.
Now updated dependencies on one of the projects on Laravel 9, and the tests failed with an exception in the migration.
In migration 2023_02_06_235146_create_permission_tables.php:78 \Spatie\Permission\PermissionRegistrar::$pivotRole returns empty value, which causes error in creating table "model_has_permissions":
... syntax error (SQL: create table "model_has_permissions" ("" integer not null, ...

Answer 13 · 2023-02-06T20:00:55.000Z

@ashvin-php try without that change, change it on vendor if it necessary, and give us a feedback

Answer 14 · 2023-02-06T20:04:42.000Z

Same error here!
SQLSTATE[42000]: Syntax error or access violation: 1166 Incorrect column name '' (SQL: create tablemodel_has_permissions ...

Answer 15 · 2023-02-06T20:05:18.000Z

I have the same problem too..

Laravel: 9.50.2
Permission package: 5.9.0
PHP: 8.2.2

The current alternative that can be done is downgrade to version 5.8.

Hopefully this issue is quickly resolved.. :)

Answer 16 · 2023-02-06T20:06:14.000Z

Hey All. I appreciate all those who tested the reset/refresh cache option and I can personally also confirm it does not work. As @ahoiroman specified, lock your version to 5.8.0 until this is resolved. In my case I did the following in my composer.json file

"spatie/laravel-permission": "<5.7",

Answer 17 · 2023-02-06T20:07:47.000Z

@erikn69 you're correct. The problem started after the last push to spatie:main 2 hours ago

Answer 18 · 2023-02-06T20:19:09.000Z

Hey All. I appreciate all those who tested the reset/refresh cache option and I can personally also confirm it does not work. As @ahoiroman specified, lock your version to 5.8.0 until this is resolved. In my case I did the following in my composer.json file

"spatie/laravel-permission": "<5.7",

@mrtorks Unfortunately did not work for me, still have the same issue for 5.7 and 5.8

Answer 19 · 2023-02-06T20:24:07.000Z

Hi, can somebody test this commit on 5.9.0 erikn69@09088c0, maybe that fix it

Answer 20 · 2023-02-06T20:52:38.000Z

@erikn69 it works!

I did a manual change in the vendor according to this reference "erikn69@09088c0" and tested it in a new project.

Answer 21 · 2023-02-06T20:58:26.000Z

I can confirm alongside @alfinauzikri That @erikn69 's solution works. I tested it on a fresh project using 5.9.0. Great Job all around. @erikn69 I think a PR is warranted.

Answer 22 · 2023-02-06T21:16:00.000Z

Hey All. I appreciate all those who tested the reset/refresh cache option and I can personally also confirm it does not work. As @ahoiroman specified, lock your version to 5.8.0 until this is resolved. In my case I did the following in my composer.json file
"spatie/laravel-permission": "<5.7",

@mrtorks Unfortunately did not work for me, still have the same issue for 5.7 and 5.8

@AhmedMub perhaps @erikn69 solution might work for you.

Answer 23 · 2023-02-06T21:40:02.000Z

v5.9.1 reverted the change.