Files added using addFile() with disk parameter are not included in final zip
AlexisSerneels opened this issue · 1 comments
AlexisSerneels commented
This issue is debugged and fixed in my PR #19
The tests were green because selectPersonalData in the User test Model was not using the optional disk parameter and then not testing against copyFileFromDisk method.
I've improved the test to cover this case scenario.
You can recreate the issue by removing $this->files[] = $pathInTemporaryDirectory; (line 88) from PersonalDataSelection.php from my PR and the test will fail.
freekmurze commented
We'll handle this in #19