spatie/laravel-searchable

Code refactoring

emilas44 opened this issue · 2 comments

emilas44 commented

here:

laravel-searchable/src/Search.php

Line 61 in 95ce9dc

$searchResults->addResults($aspect->getType(), $aspect->getResults($query, $user));

$aspect->getResults($query, $user);

uses 2 parameters but the method signature has only one!

freekmurze commented

Feel free to fix this by submitting a PR! Thanks!

emilas44 commented

I don't fully understand the concept of why is there a $user variable in the first place...
So it would be better if @AlexVanderbist could take a look at this, I mean he wrote that function after all!