spatie/laravel-slack-alerts

Incorrect type on `\Spatie\SlackAlerts\Facades\SlackAlert::to()`

dpash opened this issue · 6 comments

dpash commented

Given

   SlackAlert::to($webhook_url)
                ->message($message);

Psalm reports an error:

ERROR: UndefinedMethod - Example.php:44:31 - Method Spatie\SlackAlerts\Facades\SlackAlert::message does not exist (see https://psalm.dev/022)
                        ->message($message);

Additionally PHPStorm complains that you shouldn't call a static method dynamically, hinting at the problem.

The documentation on \Spatie\SlackAlerts\Facades\SlackAlert is

 * @method static self to(string $text)

but I think this should be changed to

 * @method static \Spatie\SlackAlerts\SlackAlert to(string $text)
freekmurze commented

Feel free to submit a PR to fix this.

  • 👎1
dpash commented

I'm sorry, did you close this without fixing it?

Nielsvanpach commented

Feel free to submit a pull request to fix this.

  • 👍2
  • 👎1
dpash commented

The issue still exists. This should not be closed. Telling me to create a PR doesn't help anyone having the same issue. It certainly isn't completed. It's WONTFIX.

Nielsvanpach commented

We develop packages for our own use and choose to open source them to assist others who may benefit. However, this does not imply an obligation on our part to provide free(!) work for resolving issues you are having or implementing features others need.

As mentioned previously, we are willing to merge a pull request that addresses the problem you are experiencing with Psalm.
Since I personally don't use this package with Psalm, I don't feel the urge to invest my spare time in fixing this.

Additionally, expressing dissatisfaction and giving a 👎 does not encourage any open source maintainer to fulfil your requests.

  • 👍2
  • 😄1
dpash commented

I'm not asking you to do anything. I'm asking you to literally do nothing. I'm asking you to not close an issue as completed when the problem still remains. As I said, if you want to close it as "won't fix" then that's also fine.

Issues are an important resource for developers to understand if other people have the same issue, potentially find solutions and to know when an issue is fixed and which release that fix is in. Closing an issue without fixing it robs the users of your project that useful resource.

For anyone else finding this issue, you can replace

SlackAlert::to($slack_webhook_url)->message($message);

with

/** @var \Spatie\SlackAlerts\SlackAlert $alert */
$alert = SlackAlert::to($slack_webhook_url);
$alert->message($message);