Return snapshot object from assertion

Question

Closed this issue 4 years ago · 3 comments

Hi,
I need to make some operations with the file generated by the assertion, and for that, it would be really useful to get the snapshot object.

If you're ok with that, I can make a PR which return the snapshot from the assertion.

Thanks.
Mathieu.

Answer 1 · 2020-12-11T11:30:56.000Z

The purist in me says that assertions shouldn't return anything. The pragmatist says it's fine.

Maybe a good in between solution would to have a dedicated method to get the snapshot for a given test.

Feel free to send a PR with tests for us to review.

Answer 2 · 2020-12-11T11:38:50.000Z

Yeah I had the same debate in me too, it why I raised an issue before. 😉

Actually for my need right now, I think I found another way than using the snapshot. But I'll do something later if it's needed.

Answer 3 · 2020-12-11T12:17:07.000Z

The purist in me says that assertions shouldn't return anything. The pragmatist says it's fine.