spatie/ssh

usePort signature should be changed

nyamsprod opened this issue · 1 comments

nyamsprod commented

Currently usePort method requires an int ?

ssh/src/Ssh.php

Line 40 in daace80

public function usePort(int $port): self

What if I create a Ssh object with a specific port and I want to remove that port ? Currently this is not possible you should change the signature to usePort(?int $port): self IMHO.

freekmurze commented

Thanks for bringing this to my attention. We'll take care of this soon by merge one of the currently opened PRs.