SPDX 2.3 Support
lumjjb opened this issue · 10 comments
Implement SPDX 2.3 support (preferably waiting on #152) for refactor changes.
2.3 Link: https://spdx.github.io/spdx-spec/v2.3/
Need help with this? I need a 2.3 model to implement a generator :)
that would be super helpful!!!!
@nishakm I also need some of the new features of 2.3 -- could I help with this?
Absolutely!
Assigned the issue to bot of you!!! Thank you!!
I'm starting to look at implementing this -- is there a document somewhere with the changes for 2.3?
Awesome @kzantow !!!! Yes! Here's the changes from 2.2 (https://spdx.github.io/spdx-spec/v2.3/diffs-from-previous-editions/)! Is this something that's useful?
You can ignore the between v2.2.x versions because they are mainly documentation changes.
@lumjjb I've added a draft PR with some initial changes for 2.3: namely a new v2_3 data model and JSON support, along with some other miscellaneous stuff. It does not yet have support for the other formats, but it will before I'd consider it done.
It should also be noted I found a number of issues with the v2_2 model that I corrected only in the v2_3 model -- namely many fields need to be omitempty. I used the JSON output and the current SPDX validator to track down a number of these issues. I may have missed some, but I think it's a lot better than the v2_2 model.
It looks like you did some of the refactoring for the current state of this repo, if you had a little time, could you have a quick look and make sure I'm on the right track before I complete everything else? This is probably the main commit to look at.
I've also added a refactoring suggestion I would like to do here: #165 I know there are some other things (like translating between versions) that people would like to see, but I feel that's a separate issue and the refactoring would dramatically improve the experience every time someone needs to implement a new SPDX version.