spencerccf/app_settings

Breaking change without changing major version number

781flyingdutchman opened this issue · 3 comments

781flyingdutchman commented

Hi, love the package, but you tripped me up (and am sure will others) by making a breaking change for 4.3.0 without changing the major version number (to 5.0.0). Flutter packages are supposed to follow semantic versioning, and this is so that when I have for example app_settings: ^4.1.1 in my pubspec.yaml file, I can be sure that nothing breaks even when pub upgrade updates my package to the latest version up to but excluding 5.0.0. Because you made a breaking change but kept the major at 4, upgrading broke compilation and it took me a while (and reading your changelog) to see that in fact you had made a breaking change.

So, friendly request next time you make a breaking change to update the major version number :)

michalsrutek commented

Same here. Thanks for the package ❤️ But please bump the major version next time there's a breaking change :)

spencerccf commented

This has been corrected... apologies for not updating for initial publish.

  • 👍1
chandrabezzo commented

Hi @spencerccf I was created new issue. I think you need retract the version from pub.dev publisher. Thanks.