spenserblack/actions-wiki

Split inline bash code into own script(s)

Closed this issue · 3 comments

Discussed in #19

Even with other alternative ideas, it seems like a safe first step is to copy+paste the code into its own .sh file. In the future, maybe use a JS action or a Docker thing or some other technique. Who knows 🤷

In the future, maybe use a JS action or a Docker thing or some other technique.

I'll say now that, if we decide that a composite action isn't enough, I'd want to make a JS action.

Pros

  • Can be used with jobs that run on Windows
  • Docker actions are often slow (it builds from the Dockerfile each run) unless the docker image is published (technically a Docker con, not a JS pro)

btw as proof (for me at least; id never seen this) you CANNOT run a Docker container-based image on Windows (at least not right now)
https://github.com/jcbhmr/.github/actions/runs/4431876234/jobs/7775293081
image
You were correct 👍

Yeah, AFAIK it's a licensing issue. As it is, GH either can't or doesn't want to use docker on Windows commercially.