Porting to Rio terminal
Closed this issue · 4 comments
Hey there, super awesome project!!!
I am actually considering to add this on Rio terminal natively so would work besides nvim. Is ok if follow your implementation and port to Rio https://github.com/raphamorim/rio ?? (or even if you would have interest on contribute)
Again thx for the project!
Hi, I'm glad you got hooked by this project!
In principle, I'm totally fine with the code being rewritten for the Rio terminal. However, due to the license I put on my code, I'll have to give you a formal written approval, since Rio is not under a GPL license.
Since you are interested in this implementation, I guess that Rio can only render text characters aligned on the terminal grid? Is it possible to superimpose two characters? How are legacy computing symbols supported? (see Cascadia Code post) Having access to "octants" symbols would make the rendering better. It would anyway be great to have an option to fallback to Rio's generated lagacy computing symbols that have the exact right shape and size, regardless of the used font.
There are currently two different implementations of how the smear is rendered. The one on v0.2.0 (shown in the demo vid), that renders two connected cursors on a line, and the one on master (wip, see #47), that renders a quad and is currently messier. Let me know which one you would choose. The code you are interested in would be in animate.lua and draw.lua.
Sadly, I don't think I'll have the time to contribute on Rio, but I'll be happy to keep an eye on the code and pull requests!
However, due to the license I put on my code, I'll have to give you a formal written approval, since Rio is not under a GPL license.
Sounds good, I will give a thought about proceed with your implementation or write a custom one to learn. In any case I will ping here either way <3
How are legacy computing symbols supported?
With cascadia code it should have support on Rio.
There are currently two different implementations of how the smear is rendered. The one on v0.2.0 (shown in the demo vid), that renders two connected cursors on a line, and the one on master (wip, see #47), that renders a quad and is currently messier. Let me know which one you would choose. The code you are interested in would be in animate.lua and draw.lua.
Sounds good!! btw do you have discord? In case want to contact you :D
Sadly, I don't think I'll have the time to contribute on Rio, but I'll be happy to keep an eye on the code and pull requests!
No worries and I appreciate any input you have on it!!
Thank you for your reply! I appreciate 🙏
@raphamorim fyi, I finished implementing rendering the smear as a quad. You can compare the look and capabilities of v0.3.0 vs v0.2.0 and see which one you prefer!