Videos should not be embeded in EPUB files

Question

Videos should not be embeded in EPUB files

adityatoshniwal opened this issue 2 years ago · 4 comments

Hi,

Thank you for the extension.
I am from pgAdmin4 team and we're creating docs with output as - HTML, EPUB and PDF. With this extension, HTML uses embedded and PDF shows links as expected. But, EPUB shows embedded which I think is not correct as EPUB is used for offline viewing. It should show a link just like PDF.
If I may raise a PR, are you willing to accept it to fix this?

Thanks.

Answer 1 · 2022-12-12T09:11:41.000Z

Yes please! Also, good timing. I was planning a release over Christmas so if you get the PR in in the next week or so then we should be able to get it up on PyPI quickly.

Answer 2 · 2022-12-12T09:18:10.000Z

@dham Thank you. Will raise a PR ASAP.

Answer 3 · 2022-12-12T10:22:07.000Z

@dham PR raised. Please review.

Answer 4 · 2022-12-19T11:24:58.000Z

PR Merged. Thanks for the contribution!