spicygreenbook/greenbook-app

App Home Page Overlay and Menu

Closed this issue · 6 comments

Put dark overlay over the image so that the text contrasts better.

Decrease height of navigation bar so there's more room for content

image

Original:

image

Recommendations are coming from this audit

I'll handle this change

Hi, I am not able to finish the second part involving bottom navigation menu. Someone else should finish this part.

Hi, I can take over for the second part involving the navigation menu.

screenshot

Second part has been implemented. While working on it, I did discover that there are two Custom Drawers that are being rendered. I'm not sure if there was a design / performance decision behind choosing one over the other so I left it as is.

Here is the code:
code screenshot

Component CustomDrawerContent is the one being rendered into the live app and it looks like this:
Simulator Screen Shot - iPhone SE (2nd generation) - 2021-05-06 at 15 37 56]

While the one that is not active but is still being called looks like this:
Simulator Screen Shot - iPhone SE (2nd generation) - 2021-05-06 at 15 39 09

Hi @lirondco nice work. I am also updating the navigation and this seems have a conflict with #363. @danilobatson can you clarify whether to remove the hamburger all together. thanks!

Drawer issue has been fixed in #394.