spicygreenbook/greenbook-app

URGENT: Volunteer Button Missing Text

Closed this issue · 5 comments

Describe the bug
Not sure what happened here but the text that was on the link to the volunteer form is now missing.

See photo below and notice empty green box

To Reproduce
Steps to reproduce the behavior:

  1. Go to spicygreenbook.org/volunteer
  2. Scroll down
  3. See error

Screenshots
image

Desktop (please complete the following information):

  • OS: [iOS]
  • Browser [chrome]

<Text style={styles.button_green_text}>Volunteer Form</Text>

button_green_text: function (config) {
return {
textTransform: "uppercase",
fontFamily: "ApercuMedium",
fontSize: 16,
lineHeight: 15,
color: theme.green,
textAlign: "center"
};

Looks like a mixup with the theming... Depending on the context of "button text color" should use: 'button_white_text' or change the color property of "button_green_text".

@JeroenGoddijn

Yeah, if the colors are changed now then the buttons have to be updated. The homepage has some buttons with the same issue.
He must have fixed the colors because button_green_text was white, but I guess in the context of the old style, it was meant for text in green buttons, which is kind of confusing.

This issue is relevant to issue #365

I will have a look later today, but pretty sure I reverted that change in commit/deployment few days ago. Right after I initially edited them.

So, somehow somewhere someone committed a fix with an older version where it was still wrong (or I could have done that accidentally myself)

Easy fix though, as we can just grab older version of getStyles.js from a previous commit and restore that one

Fix is being deployed at the moment.