Rename Ok button to Save specification in Spec editors broadly

In GitLab by @manuelma on Oct 28, 2020, 14:52

In Import editor, should we consider renaming the OK button to Save or Save specification? Similarly to Tool and Data transformer

From !5

In GitLab by @manuelma on Oct 28, 2020, 14:53

changed title from Rename Ok {-to Save specifications or something-} in Spec editors broadly to Rename Ok {+button to Save specification+} in Spec editors broadly

In GitLab by @manuelma on Oct 28, 2020, 15:17

mentioned in merge request !5

In GitLab by @PekkaSavolainen on Oct 28, 2020, 16:48

I've had this UI design principle in developing widgets that when there is something that should be saved, clicking Ok closes the widget and saves user's selections, clicking Cancel closes the widget without saving. I think it's pretty consistent throughout the app. Clicking a button that says Save specification should not close anything (expect in message boxes), it should just Save. Then you would need another button to Close the widget and I'm not really a fan of that.

In GitLab by @jkiviluo on Oct 29, 2020, 14:53

For me, the important thing is that the settings are saved when closing. I guess this is now being fixed, but it has been bit frustrating with Importer losing settings if you do something else than save the Toolbox project after closing the importer settings.

I guess I like what Pekka is saying.

In GitLab by @manuelma on Oct 29, 2020, 14:55

You're right @jkiviluo and we have an issue about that (can't remember which one). Basically what we want to do I believe is write the spec .json file when user presses ok, instead of waiting till they save the project.

Edit: I guess you don't have the 'gamer reflex', saving your progress before entering any new area...

In GitLab by @jkiviluo on Oct 29, 2020, 15:10

:) I've certainly had my share of missed save opportunities. It just that recently programs have gotten much better with saving early and often and I've forgotten my good habits.

In GitLab by @PekkaSavolainen on Dec 22, 2020, 13:00

moved to spine-tools/Spine-Toolbox#944