spine-tools/spine-items

Execution continues after a failed Gimlet item

spine-o-bot opened this issue · 0 comments

In GitLab by @ererkka on Nov 6, 2020, 17:25

It seems that the execution of a DAG continues even if a Gimlet item fails.

Simple example:

This is using standard Engine, not working at all on the experimental.

  1. Create project with two Gimlets linked with a connection.
  2. Set first gimlet to execute something meaningless, like foobar, and the other to echo something
  3. Execute whole project

Expected

Execution would stop on the first gimlet item.

Results

Both items and the whole DAG is executed successfully.

Event Log:

--------------------------------------------
Executing All Directed Acyclic Graphs
--------------------------------------------
Starting DAG 1/1
Order: Hello -> World

Executing Gimlet Hello
***
	Note: No files were copied
*** Executing in work directory ***
	Starting program cmd.exe
	Arguments: /C foobar
	Execution is in progress. See Process Log for messages (stdout&stderr)
Executing Hello finished

Executing Gimlet World
***
	Note: No files were copied
*** Executing in work directory ***
	Starting program cmd.exe
	Arguments: /C echo I’m second
	Execution is in progress. See Process Log for messages (stdout&stderr)
Executing World finished
DAG 1/1 completed successfully

Process Log:

'foobar' is not recognized as an internal or external command,

operable program or batch file.

I’m second