splintchecker/splint

5 internal splint bugs found when running splint on my fork of gdb

Opened this issue · 3 comments

cooljeanius commented

I have a fork of gdb that has a Makefile rule that loops over the source files and runs splint on each of them: https://github.com/cooljeanius/apple-gdb-1824/blob/8bc99389cdc9e41cc92c500b258d612044c8f64d/src/gdb/Makefile.in#L2143-L2184
When doing so, it reported 5 bugs internal to splint that it said to report to the old splint mailing list (which is where I originally reported this, before being told to bring it to GitHub instead).
The bugs are:

Bug no. 1.:

attempting to splint arch-utils.c
Splint 3.1.2 --- 18 Sep 2015

../bfd/libbfd.h:678:82: *** Internal Bug at usymtab.c:930: usymtab_supEntryAux:
    inconsistent state (lexlevel = 0, modFunction = true) adding:
    ? __PRETTY_FUNCTION__ [errno: 25]
     *** Please report bug to splint-bug@splint.org ***
       (attempting to continue, results may be incorrect)
Finished checking --- no warnings
   1 internal bugs reported
done with arch-utils.c

Bug no. 2.:

attempting to splint mdebugread.c
Splint 3.1.2 --- 18 Sep 2015

mdebugread.c: (in function parse_symbol)
mdebugread.c:825:17: Variable type_code declared but not used
  A variable is declared but never used. Use /*@unused@*/ in front of
  declaration to suppress message. (Use -varuse to inhibit warning)
mdebugread.c:826:8: Variable ext_tsym declared but not used
mdebugread.c:827:6: Variable nfields declared but not used
mdebugread.c:828:7: Variable max_value declared but not used
mdebugread.c:829:16: Variable f declared but not used
uentry.c:10674: at source point
mdebugread.c:1365:6: *** Internal Bug at uentry.c:10674: llassert failed:
                        res->ukind == KVAR [errno: 25]
     *** Please report bug to splint-bug@splint.org ***
       (attempting to continue, results may be incorrect)
mdebugread.c: (in function parse_type)
mdebugread.c:1502:7: Body of if clause of if statement is empty
  If statement has no body. (Use -ifempty to inhibit warning)
mdebugread.c: (in function psymtab_to_symtab_1)
mdebugread.c:4046:7: Body of if clause of if statement is empty

Finished checking --- 7 code warnings
   1 internal bugs reported
done with mdebugread.c

Bug no. 3.:

attempting to splint symfile.c
Splint 3.1.2 --- 18 Sep 2015

symfile.c: (in function copy_section_addr_info)
symfile.c:431:34: Unrecognized identifier: addrs
  Identifier used in code has not been declared. (Use -unrecog to inhibit
  warning)
symfile.c: (in function generic_load)
symfile.c:2621:3: Unrecognized identifier: gettimeofday
../bfd/libbfd.h:678:82: *** Internal Bug at usymtab.c:930: usymtab_supEntryAux:
    inconsistent state (lexlevel = 0, modFunction = true) adding:
    ? __PRETTY_FUNCTION__ [errno: 25]
     *** Please report bug to splint-bug@splint.org ***
       (attempting to continue, results may be incorrect)

Finished checking --- 2 code warnings
   1 internal bugs reported
done with symfile.c

Bug no. 4.:

attempting to splint i386-macosx-tdep.c
Splint 3.1.2 --- 18 Sep 2015

../bfd/libbfd.h:678:82: *** Internal Bug at usymtab.c:930: usymtab_supEntryAux:
    inconsistent state (lexlevel = 0, modFunction = true) adding:
    ? __PRETTY_FUNCTION__ [errno: 25]
     *** Please report bug to splint-bug@splint.org ***
       (attempting to continue, results may be incorrect)
Finished checking --- no warnings
   1 internal bugs reported
done with i386-macosx-tdep.c

Bug no. 5.:

attempting to splint macosx-nat-dyld-io.c
Splint 3.1.2 --- 18 Sep 2015

../bfd/libbfd.h:678:82: *** Internal Bug at usymtab.c:930: usymtab_supEntryAux:
    inconsistent state (lexlevel = 0, modFunction = true) adding:
    ? __PRETTY_FUNCTION__ [errno: 25]
     *** Please report bug to splint-bug@splint.org ***
       (attempting to continue, results may be incorrect)
Finished checking --- no warnings
   1 internal bugs reported
done with macosx-nat-dyld-io.c

Please let me know what other information I should provide, such as sources, or preprocessed versions thereof.

cooljeanius commented

@bpringlemeir are you still maintaining this?

bpringlemeir commented
cooljeanius commented

No, I have credential to the repository, if you want to maintain it.

Thanks for the offer, but I don't think I'm qualified to do so; I'd probably just make a mess of it...