splitwise/super_diff

Breaks RSpec extra failure lines support

palkan opened this issue · 2 comments

palkan commented

RSpec metadata[:extra_failure_lines] are not honored by super_diff.

This mechanism is used by rspec-rails system tests integration to display the link to a failure screenshot. With super_diff, we don't have this information in output.

mcmire commented

Ah. super_diff patches RSpec across the board to color different parts of the output, including ExceptionPresenter, and looking at the code again, I don't think this functionality is being included. This should be a fairly easy one to integrate. I can look into this when I get a chance, although a PR would certainly be welcome.

  • 👍1
mcmire commented

I was looking through the issues list and noticed that this issue is already filed as #108. So I'm going to close this as a duplicate but keep the other one open for tracking.

  • 👍1