splunk/kafka-connect-splunk

Wrong version

FranciscoGualdi opened this issue · 2 comments

The version o the tagged releases are wrong. I downloaded the version 1.2.0 but the version returned by the connect framework is 1.0.0.
curl localhost:8083/connector-plugins | jq

{
"class": "com.splunk.kafka.connect.SplunkSinkConnector",
"type": "sink",
"version": "v1.0.0"
},

Opening the jar file and see version.properties:
githash=@1e92a95
gitbranch=release/1.0.x
gitversion=v1.0.0

@FranciscoGualdi Thanks for bringing this up, it is a known issue and the fix will be included in the next release.

Hello, just noticed that the latest version (currently v2.0.2) also suffers from this issue:

[
  {
    "class": "com.splunk.kafka.connect.SplunkSinkConnector",
    "type": "sink",
    "version": "v2.0.1"
  }
]

I think that the problem is that when building the JAR file, the Git repository is not tagged yet to the new version, therefore this snippet bakes the wrong version into the version.properties file:

gitversion=`git describe --abbrev=0 --tags 2>/dev/null` # returns the latest tag from current commit