sportsdataverse/cfbfastR

EPA on Punt plays looks broken

rebinion opened this issue · 1 comments

rebinion commented

Describe the bug
The EPA on punt plays does not seem to be factoring correctly.

To Reproduce

  1. Go to the play by play data
  2. Filter play_type == "Punt"
  3. Observe how many punt plays include very large EPA numbers for the defensive team on uneventful plays

Expected behavior
For punt plays that net out to around 40 yards, the EPA should be minimal.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Kazink36 commented

This should be working properly as of cfbfastR 1.9.0

Feel free to reopen if you still see any funky results.