spotify/basic-pitch

Inconsistent minimum note length

matangover opened this issue · 3 comments

Since #39 was merged, there is an inconsistent minimum note length:

  • When calling predict it's 127.7 ms (11 frames)
  • When using the command line it's 58 ms (5 frames)
  • In predict_and_save the default is 58 ms
  • In model_output_to_notes the default is 5 frames

I can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?

Also, funnily enough, the minimum note length in basicpitch.io says it's in milliseconds, but it seems to be in frames.

Hey @matangover, nice catch! I've made a PR to resolve all minimum_note_length to 127.70 ms. Once it is merged I will resolve this issue.

Thank you!