Packer class not compatible anymore with Spree 2.4
papayaah opened this issue · 2 comments
A call to product_assembly_package is completely incompatible with spree 2.4. The current Packer class still expects an order and loops through line items but the one in 2.4 no longer accepts an order instance and uses inventory_units to loop through
Also goes the same with the AssemblyPrioritizer where a call to Adjuster.new is not conforming to the revised Adjuster class on Spree 2.4.
I'm wondering if there's any plan to update this in the near future?
I've started a 2-4-beta branch to start making this gem compatible with 2.4, not done much with it yet though - I can look at this issue at some point when I have some free time (probably not today, maybe sometime in the next day or so), or if you want to open a PR go for it.
current master should be 2.4 compatible, 2-4-stable branch coming soon, cheers