Is this "master" compatible?
MicFin opened this issue · 4 comments
Most extensions seem to ride the master and I am trying to use a few so I was wondering if this is compatible with master. I am receiving the following error
/Users/Mike/.rvm/gems/ruby-2.0.0-p353/gems/actionpack-4.0.4/lib/action_dispatch/routing/mapper.rb:191:in normalize_conditions!': You should not use thematchmethod in your router without specifying an HTTP method. (RuntimeError) If you want to expose your action to both GET and POST, addvia: [:get, :post]option. If you want to expose your action to GET, useget` in the router:
Instead of: match "controller#action"
Do: get "controller#action"
It's working on Spree 2.1.x and should just work with Spree 2.2.x as far as I know.
I haven't yet updated this for the latest and greatest spree, but the update should be fairly trivial if any are needed.
Are you using the master branch or what do you have in your Gemfile?
I tried
"gem 'spree_contact_us', :git => 'https://github.com/jdutil/spree_contact_us'"
I received the following
"Bundler could not find compatible versions for gem 'spree_core':
In Gemfile:
spree_contact_us (>= 0) ruby depends on
spree_core (~> 2.2.0.beta) ruby
spree (>= 0) ruby depends on
spree_core (2.3.0.beta)"
and
"gem 'spree_contact_us'"
I received the error above.
If you run bundle update master branch should be compatible with spree master now.
Thank you for being so helpful. It's a great gem!