Issue with order concurrency refactor in 2-1-stable

[paultyng]

Using latest spree/spree@bf68120 and bc2bc75

Getting the error below. I imagine its related to this somehow: spree/spree#4334

undefined local variable or method `load_order' for #Spree::CheckoutController:0x00000007a86270

I guess it was renamed to load_order_with_lock? I can submit a quick PR if that is the case.

/usr/local/rvm/gems/ruby-2.0.0-p353/bundler/gems/spree_store_credits-3589755b7230/app/controllers/spree/checkout_controller_decorator.rb:11:in `remove_payments_attributes_if_total_is_zero'
warden (1.2.3) lib/warden/manager.rb:35:in `block in call'
warden (1.2.3) lib/warden/manager.rb:34:in `catch'
warden (1.2.3) lib/warden/manager.rb:34:in `call'
rack (1.5.2) lib/rack/etag.rb:23:in `call'
rack (1.5.2) lib/rack/conditionalget.rb:25:in `call'
rack (1.5.2) lib/rack/head.rb:11:in `call'
rack (1.5.2) lib/rack/session/abstract/id.rb:225:in `context'
rack (1.5.2) lib/rack/session/abstract/id.rb:220:in `call'
better_errors (1.1.0) lib/better_errors/middleware.rb:58:in `call'
quiet_assets (1.0.2) lib/quiet_assets.rb:18:in `call_with_quiet_assets'
rack (1.5.2) lib/rack/methodoverride.rb:21:in `call'
rack (1.5.2) lib/rack/runtime.rb:17:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
rack (1.5.2) lib/rack/sendfile.rb:112:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
rack (1.5.2) lib/rack/content_length.rb:14:in `call'
rack (1.5.2) lib/rack/handler/webrick.rb:60:in `service'
/usr/local/rvm/rubies/ruby-2.0.0-p353/lib/ruby/2.0.0/webrick/httpserver.rb:138:in `service'
/usr/local/rvm/rubies/ruby-2.0.0-p353/lib/ruby/2.0.0/webrick/httpserver.rb:94:in `run'
/usr/local/rvm/rubies/ruby-2.0.0-p353/lib/ruby/2.0.0/webrick/server.rb:295:in `block in start_thread'

[paultyng]

Renaming seemed to fix it for me locally, my tests are passing now.