When adding a line item promotion to an order taxes are not re-adjusted with TaxCloud.

[Lyonsclay]

When using the Spree::Calculator::DefaultTax an additional tax total is recalculated after applying a line item promotion to an order, however when using the Spree::Calculator::TaxCloudCalculator the taxes are not adjusted after applying the promotion.

Gemfile.lock -- https://gist.github.com/Lyonsclay/2480bf8229afc1a07a0a123343875c28

I have created a repo with a default Spree 3.0.8 app and added a test that demonstrates the behavior.

https://github.com/Lyonsclay/spree_3-0-stable_app

Clone the repo, run bundle install, and spec.

[Lyonsclay]

Just noticed this in the source code for TaxCloudCalculator;

TODO take discounted_amount into account. This is a problem because TaxCloud API does not take discounts nor does it return percentage rates.

[lmirosevic]

+1

[cyu]

I've submitted a PR (#37) that addresses this. For 3-0-stable, but the change should work on the newer branches as well.

[cyu]

#38 addresses master