spring-cloud/spring-cloud-commons

Custom metric's tag for MicrometerStatsLoadBalancerLifecycle

mario45211 opened this issue · 1 comments

Is your feature request related to a problem? Please describe.
I'm integrating Spring Cloud LoadBalancer with a Consul Discovery Client and I want to include own Consul's instance tags in metrics from Load Balancer.

Describe the solution you'd like
I'd like to register custom customizer bean, which could enrich micrometer's tags for load balancer metrics.

Describe alternatives you've considered
I've Implemented own LoadBalancerLifecycle to gather metrics only to add few tags, but it seems tedious, especially having mechanism in a MicrometerStatsLoadBalancerLifecycle class.

Hello @mario45211, thanks for reporting the issue. I'm going to label it as enhancement, however, since it can be done by implementing the LoadBalancerLifecycle and we have not had more requests for this kind of feature, we might not give it high priority. Would you like to create a PR?