spring-cloud/spring-cloud-dataflow

AppRegistryController Deprecation cleanup

Closed this issue · 1 comments

cppwfs commented

AppRegistryController currently there are 2 Deprecations that need to be removed.

  • register
  • info
    These deprecations were added in 2017 when we added versions for registration.

Conversely we need to add 2 more Deprecations for the current API's as they have an optional bootVersion that is no longer supported.

AppRegistryOperations:

  • register - Move the Deprecated annotations to the methods that have the bootversion enumerated. But also investigate to see if the method at line 87 needs to be removed.
cppwfs commented

After working on this issue. I could find no reason for these deprecations.
In the original case that added the deprecations they added the ability to override the version provided in the URL of the application.
So why remove the capability of acquiring the version from the URL of the app (jar/container). Plus the shell does not currently support the ability to override the version.

It is my recommendation that we remove the Deprecated annotations.