Deserialization problem with Spring Cloud Stream & Spring Cloud Function

Question

Deserialization problem with Spring Cloud Stream & Spring Cloud Function

mfrechePgest opened this issue 4 months ago · 8 comments

Describe the issue

Since Spring Cloud 2023.0.3, most of our Spring Cloud Stream bindings are failing to deserialize JSON objects.
It seems Jackson property DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES is now enabled by default.
It wasn't the case in 2023.0.2.

If I send in my message queue a JSON object with more fields than the DTO knows about : it fails during deserialization.

To Reproduce
Here is a sample repo where problem is shown.
There are 2 branches with each Spring Cloud version.

You can execute MessagingStreamsIT.
Every test runs fine in 2023.0.2 branch, while it fails in 2023.0.3.

As it's shown in some tests, adding @JsonIgnoreProperties(ignoreUnknown = true) on every DTO object seems to be a workaround.

Answer 1 · 2024-07-17T14:12:00.000Z

Indeed we just added it to solve another issue. i will take a look and see what we can do

Answer 2 · 2024-07-17T14:14:45.000Z

Here is the issue where it was introduced - #1097

Answer 3 · 2024-07-17T14:17:58.000Z

Actually i take this back, the only deserialisation feature we have currently is mapper.configure(DeserializationFeature.FAIL_ON_TRAILING_TOKENS, true);.
Where do you see it being set?

Answer 4 · 2024-07-17T14:20:16.000Z

I didn't, actually

Symptoms are just "as if" this property was forced under the hood.

Answer 5 · 2024-07-17T14:34:54.000Z

Let me try your sample

Answer 6 · 2024-07-17T15:15:13.000Z

I see the issue. It's in s-c-function. I will transfer it there and push the fix shortly

Answer 7 · 2024-07-19T09:04:38.000Z

Seems like PR #1162 addressed the same issue in a diffrent way too

Answer 8 · 2024-07-22T08:23:18.000Z

@olegz This fix doesn't resolve the problem of not all modules being registered. For instance the Kotlin-Module is not registered and that leads to problems when using Kotlin (data classes).