spring-cloud/spring-cloud-open-service-broker

Service instance labeling

zoharyehezkely opened this issue · 9 comments

zoharyehezkely commented

Hi,

Following this issue: https://github.com/spring-cloud/spring-cloud-open-service-broker/issues/311
Regarding support for the labeling service instances.
I saw that in OSB master, fetching a Service Instance returns also the metadata
https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#fetching-a-service-instance

Is this implementation planned for the next release?

Thanks,
Zohar.

zoharyehezkely commented

Hi,

I have an implementation ready here:
zoharyehezkely@f765069

Can someone assist with merging it to master?
Thanks,
Zohar.

zoharyehezkely commented

I have created a PR here:
#349

royclarkson commented

@zoharyehezkely thanks for the PR. It appears that change to the response body for fetching a service instance is not part of OSB API 2.16. Because it hasn't been released as part of a versioned specification, we can't include yet. Anything that is unreleased in master can potentially change, even if unlikely. We'll be happy to merge this once it is included in a released spec.

zoharyehezkely commented

@royclarkson - Any idea when the next OSB release is due?

Thanks,
Zohar.

zoharyehezkely commented

Hi @royclarkson,
There is a PR for OSB API 2.17 waiting for reviewers:
openservicebrokerapi/servicebroker#751
I was told there are 2 people on the committee from vmware.
Can you check from your side if it is possible to notify them for assistance here?

Thanks,
Zohar.

zoharyehezkely commented

Hi,

Any updates on this issue?

Regards,
Zohar.

zoharyehezkely commented

Hi @royclarkson
Any new updates on this issue?

Thanks,
Zohar.

royclarkson commented

@zoharyehezkely we have to finalize the OSB 2.16 support first in a release, and then I'll get this added for future 2.17 support. It will probably be a version 4.1. Thanks for your patience.