spring-cloud/spring-cloud-openfeign

Upgrade to fileupload2

MelleD opened this issue · 6 comments

Is your feature request related to a problem? Please describe.
Outdated and old dependencies from fileupload make some issues with other libs.

Describe the solution you'd like
The Artifact Id and version of FileUpload will change. In this version many transitive dependency versions are raised. It would be great if spring feign cloud include the new FileUpload 2 version directly.

See https://github.com/apache/commons-fileupload/blob/master/pom.xml#L27
<artifactId>commons-fileupload2</artifactId>

If something is breaking the M2 could be used for a small test
https://central.sonatype.com/artifact/org.apache.commons/commons-fileupload2

Hello @MelleD, we only provide fileupload to avoid transitive vulnerability from feign-form as they have not released an upgrade. Please report it there.

Hello @OlgaMaciaszek, looks like you need a new or own project from feign-form. The last change is 5 years ago in this project and the only use case is here:
https://github.com/OpenFeign/feign-form/blob/master/feign-form-spring/src/main/java/feign/form/spring/converter/SpringManyMultipartFilesReader.java#L33

Off course I can also exclude the feign-form, but in future it see that you should remove this dead project.

I understand, however the entire Spring Cloud OpenFeign project is now in maintenance mode only. We fix bugs and stay on top of vulnerabilities, but not much more. We suggest migrating over to Spring Interface Clients moving forward. The feign-form project is independently maintained.

I understand, however the entire Spring Cloud OpenFeign project is now in maintenance mode only.

Oh ok good to know, is there a public announcement?

We suggest migrating over to Spring Interface Clients moving forward. The feign-form project is independently maintained.

Do you mean this one?
https://docs.spring.io/spring-framework/reference/web/webflux-http-interface-client.html
and
https://www.baeldung.com/spring-5-webclient

@OlgaMaciaszek thanks a lot