[Feature Request] Allow to accept a list of customizers instead of a unique one for KafkaMessageChannelBinder
yiliuTo opened this issue · 3 comments
Describe the issue
Currently for KafkaMessageChannelBinder, it can only accept a single instance for ClientFactoryCustomizer, ProducerConfigCustomizer and ConsumerConfigCustomizer each. While this might be a block when there is need to carrry out secondary development on the binder configs/factories by using those customziers in a another library. Because in this way if both the library and users provide their own customziers, then neither of them can take effects.
Version of the framework
Library: org.springframework.cloud:spring-cloud-stream-binder-kafka
Expected behavior
For KafkaMessageChannelBinder, hope it can hold a list of those customizers instead of a single one. And then for the KafkaBinderConfiguration, it doesn't need to get the unique one, but can use the similar way of Spring Boot Kakfa Autoconfiguration to add all of them to the binder.
Additional context
Copy the issue in spring-cloud/spring-cloud-stream-binder-kafka#1217 in case that's not the repo to raise issues for kafka binder.
@yiliuTo What you are proposing makes complete sense to me. Do you want to work on a patch and send us a PR? But we can certainly look at this if you can't get to it. Let us know either way. Thank you!
@sobychacko thanks for the quick feedback! Also of course I would like to create a pr for that! I will link to this issue when I create the PR
Hi @sobychacko , I created a PR for this issue, please help to take a look and review when you are available, thanks!