spring-io/spring-javaformat

Comments are not always formatted properly on the first pass

Opened this issue · 1 comments

When formatting the class below

public class Main {// issue


}

you first get:

public class Main {

// issue

}

which fails validation

on the second run it generates:

public class Main {

	// issue

}

which passes.

Similarly formatting this class:

public class Main {//issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue issue

}

generates:

public class Main {

// issue issue issue issue issue issue issue issue issue issue issue
					// issue issue issue issue issue issue issue issue issue issue issue
					// issue issue issue issue issue issue issue issue issue issue issue
					// issue issue issue issue issue issue issue

}

which fails on both the first and subsequent lines, with both too little and too much indentation

I can't reproduce this with a stock Eclipse install using the same org.eclipse.jdt.core.formatter.* settings so it would appear to be specific to Spring Java Format. I wonder if CodeLineBreakPreparator is involved.