Home page carousel is borked.
dcporter opened this issue · 5 comments
New items enter from the left while old items depart to the left.
As far as I can tell, this is working "as designed". It was apparently hand-written by whoever developed the page.
Should we consider dropping in a jQuery plugin or something instead?
yes yessss
I attempted to do this, but realized that we're on a REALLY old version of jQuery and most of the sliders I found require a newer version. I tried to upgrade jQuery but that broke other things. I can investigate again later, but I'm honestly not sure if it's worth spending a ton of time on.
I don't recall the details, but isn't this a home-grown carousel? I would think it could be fixed in place without too much effort. But yeah annoying code is annoying; I defer to you.
As for upgrading jQuery, I think that comes down to whether we're planning to upgrade the website piecemeal, or put that off in favor of a full overhaul. I would love a full overhaul with a more modern look and layout, but I would love lots of things. Thoughts?
The carousel is indeed home grown, and the code is pretty messy and horrible. It may be possible to fix this, but I spent about 30 minutes trying to figure out how the stupid CSS classes work (they attach webkit transitions by adding or removing classes), but I was never able to get old items to depart to the right.
I can try again, but as stated in today's meeting, time-consuming tasks to fix non-horribly-egregious should be avoided.
That said, if someone else wants to dive in and see if they can figure out the CSS classes or fix the JS to work better, please feel free; I won't be offended :-)