sqids/sqids-php

Is it in preparation?

Closed this issue · 14 comments

roukmoute commented

I've come from this link: hashids/hashids.github.io#44. As a result, I was wondering whether you've considered implementing this feature yourself in PHP, or whether you're waiting for a new maintainer to step in.

As soon as this feature is available in PHP, I'd be delighted to contribute by adapting it for Symfony, if that suits your needs. I look forward to collaborating on this project.

miquelfire commented

They might be waiting on a maintainer. I feel what is basically Hashids v2 came out way too quick, so some languages don't have active people to implement the new version.

  • 👍1
roukmoute commented

@4kimov

I'd be delighted to take on this task if no one has started working on it yet, and if you don't intend to do it yourself. I'm ready to do my bit to move this project forward.

miquelfire commented

If you have time, go ahead. I'm just here as a user.

4kimov commented

@roukmoute Thanks for pinging. Just haven't gotten to implementing PHP yet.

@vinkla Should I start or would you like to adjust https://github.com/vinkla/hashids to the new spec?

vinkla commented

@vinkla Should I start or would you like to adjust vinkla/hashids to the new spec?

Thank you for asking. Please go ahead and start. Unfortunately, I don't have much time at the moment. I can assist you with Laravel integration later. You can refer to this repository for my initial attempt, in case it is helpful.

4kimov commented

@vinkla Cool, will do. Thanks for the heads up.

I'd be delighted to take on this task if no one has started working on it yet

@roukmoute Are you referring to the core PHP library or Symfony integration?

  • 👍1
roukmoute commented

@4kimov To begin with, I'm going to focus on the PHP library

Thanks @vinkla for the attempt 👍

vinkla commented

@roukmoute Ivan published 0.0.1 yesterday, please see the main branch.

roukmoute commented

Thank you for this information. I was not aware of this update. I suppose it would be better to wait for a stable release and I'll concentrate on the Symfony version afterwards.

vinkla commented

I believe you can proceed with the Symfony version. There won't be many changes. I have a ready-to-use Laravel package. I suggest publishing it as sqids/laravel. It would be a good idea to name the Symfony package as sqids/symfony. Let's wait for @4kimov's opinion on this.

4kimov commented

Hey all, quick update on the repo:

  • Main lib is there, but needs lots of cleanup
  • Tests are also there, but also need lots of cleanup
  • Math functions need to be replaced with bcmath/gmp
  • I'm sure the repo needs lots of general cleanup, @vinkla is already helping with that

I registered v0.0.1 just so there's something there. Regarding framework support / plugins, I think they're more appropriate for individual user repositories, so feel free to create them under your own usernames. I'd like the sqids Github org to be supporting the 40+ core libs, so that they're a solid foundation to build on top of. If framework repos are under the same roof, it might get a bit too busy.

As far as this repo, if anyone wants to bring it to the finish line, by all means; otherwise, I'll wrap it up hopefully in a few days.

vinkla commented

A Laravel version is currently being developed: https://github.com/vinkla/sqids

tobsn commented

is there no salt available?

4kimov commented

@tobsn

why removed: https://sqids.org/faq#salt
how to have unique ids: https://sqids.org/faq#unique

  • 👍1