Why create a new QueryFactory when it can be assigned via an XQuery property
Opened this issue · 1 comments
Deleted user commented
Hi,
Why create a new QueryFactory when it can be assigned via an XQuery property.
internal static QueryFactory CreateQueryFactory(XQuery xQuery)
{
//I don't understand what is the meaning of this new creation?
var factory = new QueryFactory(xQuery.Connection, xQuery.Compiler); // Original
//While it can be assigned like this:
var factory = xQuery.QueryFactory; // Another solution
factory.Logger = xQuery.Logger;
return factory;
}
Thanks
generik0 commented
Looks like a candidate for an extension method in the package.
Why not fork, and maybe a PR?