square/SquarePointOfSaleSDK-iOS

Carthage build fails for the last release (3.4.0)

rl-pavel opened this issue · 14 comments

Last release broke carthage builds, causing this error:
Dependency "SquarePointOfSaleSDK-iOS" has no shared framework schemes

image

Locking the framework to 3.3.2 fixes the issue for now.

@Pahitos sorry about that, try again. I just uploaded the binary manually

@MikeSilvis hi, unfortunately I'm still running into the same issue :(

From what I understand, there might be something wrong with the project/scheme config. Here are a few issues that might have some helpful details:
Carthage/Carthage#1109
techprimate/TPPDF#98

@Pahitos can you try clearing your Carthage cache?

m -rf ~/Library/Caches/org.carthage.CarthageKit

I just tried pulling and got it to work:

2.4.4 Test
 ➲  carthage update
Please update to the latest Carthage version: 0.34.0. You currently are on 0.33.0
*** Cloning SquarePointOfSaleSDK-iOS
*** Checking out SquarePointOfSaleSDK-iOS at "3.4.0"
*** xcodebuild output can be found in /var/folders/td/0lcyjgbx5cz4tj2tgmckz8mc0000gn/T/carthage-xcodebuild.TMNShi.log
*** Downloading SquarePointOfSaleSDK-iOS.framework binary at "Further iOS 13 Support"

@MikeSilvis still the same issue... What do you have in your cartfile? Is it just github "Square/SquarePointOfSaleSDK-iOS"? I also noticed you're running carthage 0.33.0, could the issue be with the newer version (0.34.0)?

@Pahitos mind bringing this to Slack?

Our community: https://squ.re/2Hks3YE

You aren't by chance using:

carthage update --no-use-binaries

Are you?

@MikeSilvis ah, this was in fact the issue. We have a script that updates all our dependencies across multiple projects, which uses this. It seems to work fine without it for now, but is there any reason Square's SDK can't be updated when using this in the future?

Still trying to figure out the best course of action, but this is what i'm hitting: Carthage/Carthage#2965

@MikeSilvis I'm now also running into an issue where I can't run the app on a physical iOS device. I think this might be a different problem than the above, but this doesn't happen when using --no-use-binaries with the older version.

image

I haven't tried, but I think this would also break the deployment of App Store builds. Do you mind reopening this issue please? And let me know if you need any other info that could help resolve this.

Shoot @Pahitos i know what this is. I’ll have to resubmit the binary as a FAT framework including both the simulator and device binary.

#82

I already re-uploaded the binary to the release. Try now! Sorry about all of this

@MikeSilvis no worries, it happens 😄
So the normal carthage update seems to work and the app runs fine on a physical device, but when using --no-use-binaries, I still get the same error as in my first post. I take it that will be fixed once Carthage/Carthage#2965 is merged?

Exactly, depending on Carthage's release time I also might do a follow up to work around their limitations.

Looks like this should now be resolved on Carthage's side Carthage/Carthage#2965 (comment)