square/keywhiz

MySQL version in README.md

yardenshoham opened this issue · 1 comments

yardenshoham commented

The README.md mentions any version higher than 5.7 is fine:

keywhiz/README.md

Line 15 in 5c5eb37

Keywhiz requires Java 11 and MySQL 5.7 or higher.

But I don't think that's true as I tried building the Dockerfile with mysql 8 running, specifically 8.0.21, and it failed. I assumed it'd worked because I looked here:

keywhiz/pom.xml

Line 49 in 5c5eb37

<mysql.version>8.0.21</mysql.version>

I think we need to investigate which mysql version is the maximum allowed for keywhiz.

Note: travis uses 5.7.30.

jagadish-pobba commented

Hi,

Also faced same issue yesterday while using Mysql 8.0.12 (Community Edition).
Install failed while creating table for groups. groups is reserved word in MySQL from 8.0 onwards

Also MySQL 8 doesn't allow passwords to be empty by default. Need to disable validations to create a new login with empty password.

Worked fine with MariaDB 10.5 - with one exception in Testcase (12 times) - "Failed to SetAutoCommit"
Skipped testcases using this flag: mvn install -Dmaven.test.skip=true

Documentation available for first time users is very limited. A Video tutorial with installation, dependencies and usage will definitely help a lot of users