Kochiku-worker assumes Kochiku server is on HTTPS
Closed this issue · 4 comments
lib/kochiku/jobs/build_attempt_job.rb has https hardcoded. It's not going to take long before someone is going to run into this because I assume that most people will serve Kochiku over http.
I assume the best solution is to add a configuration option for this?
I would certainly advocate https for everything, but no objection to making this configurable.
https can be annoying because it requires putting a certificate in place on the server and the certificate needs to be trusted or the browser thinks the world is ending.
kochiku doesn't have user accounts so I can see a lot of people running it on HTTP within their private network.
I agree with annoying, but this is doable in a variety of ways, such as running a private certificate authority. Different browsers also freak out to differing extents. But it isn't kochiku's job to worry about this stuff, so there's not much point in debating it here.