square/workflow-swift

Consider swapping the generic parameters on ContainerViewController

bencochran opened this issue · 1 comments

bencochran commented

ContainerViewController is currently ContainerViewController<Output, Rendering> whereas AnyWorkflow is AnyWorkflow<Rendering, Output>. This inconsistency has tripped me up a few times, and I don’t personally see a concrete reason for this ordering over the other. If we want to make these match, pre-1.0’s the time.

AquaGeek commented

I'd be fine changing this to make them consistent. Any thoughts, @dhavalshreyas?

FYI, we have 55 usages of this internally, so not terrible to migrate.

  • 👍1