calculatePrival has some bugs

Question

tereska opened this issue 13 years ago · 4 comments

What if pri.severity is equals 0 (which is severity 'emerg': 0, ) ??
It will become falsy and and will jump to else statment and return false!

the same thing with pri.facility 'kern': 0

Answer 1 · 2011-10-03T10:06:03.000Z

Thanks for spotting this. I'll have a look at fixing it shortly.

Answer 2 · 2011-10-03T14:15:28.000Z

This should hopefully be addressed in 98d4f54, let me know if anything else comes up.

Thanks.

Answer 3 · 2011-10-03T15:31:09.000Z

it works thanks!

Answer 4 · 2019-07-29T16:32:01.000Z

This piece seems to work ok but it depends on how you call produce. I use winston-syslog and it doesn't pass in facility when it calls .produce. So when it gets to this line, https://github.com/squeeks/glossy/blob/master/lib/glossy/produce.js#L154, this.facility is undefined because it will never set this.facility https://github.com/squeeks/glossy/blob/master/lib/glossy/produce.js#L114. It looks like there hasn't been a release in man years but if I open a PR would it get some 👀 ?