srdtrk/cw-ica-controller

Remove callback counter

srdtrk opened this issue · 0 comments

srdtrk commented

Description

CallbackCounter was initially used in tests when the contract didn't have callback capabilities. It is now a redundant relic.

Proposal

The removal is pretty straightforward. The e2e tests need to be refactored not to use callback counter, I can see 2 ways forward:

  1. Simply remove callback counter assertions from the e2e tests.
  2. Use the owner testing contract to store the counter.
  3. Create a new callback testing contract with the counter.