srod/node-minify

Update v.3.1.1 triggers an e.$watch error when minifying angular.min.js library

tabish89 opened this issue · 3 comments

I inadvertently updated my local node modules to v.3.1.1 of node-minify and when I executed the command to compress/minify my application, it started to trigger the following error:

TypeError: e.$watch is not a function

I research this error and learned that it had something to do with how angular.js was being minified. I backtracked to v.3.1.0 and reran the process... and, everything worked fine. This is using v.1.4.8 of angular.

Just wanted to bring this to your attention.

I'm not an advanced coder. Just know enough to be dangerous.

srod commented

Thank you, I will have a look to angular.
Do you know wich compressor you are using ?
It's in the command.

@srod

I'm sorry for not having responded earlier. Here is a snippet from code:

var vendor_js_promise = Promise.resolve(undefined) vendor_js_promise = compressor.minify({ compressor: 'uglifyjs', input: vendor_js_files, output: 'public/dist/vendor-bundle.min.js', callback: function(err, min) { console.log('Successfully Minified Vendor JS Files!'); } })

I think we're using uglify-js and I think you have already figured that out.

srod commented

Don't worry, the ticket was closed automatically because of my commit.
I've figured it out, and release 3.1.2