sroegner/codebook

Language files and more options

Closed this issue · 5 comments

I just installed your plugin and it went fine besides the lang files, but I am not exactly sure if I had to copy the language stuff manually like I did to get it working.

I have two feature requests and I wanted to ask you before hacking your code:

  1. An option to toggle line numbers on by default
  2. A download option to save the code to a file and/or display it raw.

Hmmm. I was not aware of any manual operation involved in getting the localization to work. Can you give me a bit more detail what went wrong and what you did to fix it (maybe in a separate issue)?

As of your suggestions:

  1. seems simple enough, I'll look into it
  2. I was thinking along the lines of a complete import/export functionality, but have not come up with a solution, any suggestions (or hacks, for that matter) are welcome. Easiest way here is usually you forking my code and me merging it back into my mainline later.

I pushed a new release with what looks like a working preference for showing line numbers. No migration necessary!

Thanks for your fast reply, well I just installed your extension via git and restarted my redmine (Revision: 2835) instance. And the localization didn't work, are you relying on the redmine localization stuff? I only managed to enable it with concatenating the content of the lang files to the redmine ones.
You can see it here: http://omploader.org/vMjQxZw

Your changes about the number displaying preference work without a flaw - besides the localization - of course.

I am sorry - I tried with a fresh production instance, but could not reproduce the problem. All I had to do was to install db:migrate the plugin and all languages appeared to work.
What version of redmine (mine is 0.8.4) and web server (apache+passenger 2.2.4 here) are you using?

It's just strange, I am using redmine revision 2835 with mongrel/pound. db:migrate doesn't help here.