srush/Triton-Puzzles

viz=False does not work

Opened this issue · 1 comments

I don't really understand the visualizations tbh, so I wanted to turn them off, but viz=False, leads to the following error:

---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
[<ipython-input-44-e13ba08403d2>](https://ucrqhfq45wo-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab_20240403-060136_RC00_621473488#) in <cell line: 28>()
     26     tl.store(z_ptr + n0_range + n1_range * N0, z, mask)
     27 
---> 28 test(add_vec_block_kernel, add_vec_block_spec, nelem={"N0": 100, "N1": 90}, viz=False)

[<ipython-input-3-91403af2aaed>](https://ucrqhfq45wo-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab_20240403-060136_RC00_621473488#) in test(puzzle, puzzle_spec, nelem, B, viz)
     40     if viz:
     41         failures = triton_viz.launch()
---> 42     if not match or failures:
     43         print("Invalid Access:", failures)
     44         print("Yours:", z)

UnboundLocalError: local variable 'failures' referenced before assignment

changing the test code a bit to something like this in the relevant lines worked for me:

failures=None
if viz:
    failures = triton_viz.launch()
if not match or failures:
    if failures:
        print("Invalid Access:", failures)

Can you let us know what is unclear about the visualizations? I think that would be useful for us.